-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add control for removing stopped docker containers. #1290
Conversation
Maybe after the play button? Or is there a specific reason for putting it first? |
Also, removing a container takes 15 seconds (so looks like the control hasn't worked), then the details panel breaks (but stays open). |
No reason, will do.
I have no intention of dealing with this in this PR, if thats alright. |
Actually, there sorted alphabetically. We can't control the order of them. |
This will be fixed in #1363
@davkal / @foot any ideas here? We leave the details panel open for good reason (reconnects etc), but perhaps you could close it if you receive a Remove node diff? But not if the ws goes away? |
The details panel can handle 404s initially. Perhaps if it gets a 404 while waiting for a control to complete something bad happens. Will have a look. |
Yes, we can close the details panel on node remove (we're already handling missing mouseout events that way). Otherwise we could do control update requests to get the status on a control action. |
I propose this lifecycle-ish order: start - restart - pause - stop - remove |
Could also be done in-band, in the control response. We just need to agree on a field. Eg. terminal controls return |
Scratch that, lets be explicit. |
e35c982
to
ed555b6
Compare
I think thats all the feedback addressed - @paulbellamy PTAL? |
RawTTY bool `json:"raw_tty,omitempty"` | ||
|
||
// Remove specific fields | ||
RemovedNode string `json:"removedNode,omitempty"` // Set if node was removed |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
I'm treating the removal in the UI only. |
50df0d4
to
eda2a20
Compare
Also fixes #1367